Fix arrow keys not working in tag editor on qt 6.8 #4114
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3751
On windows and on qt 6.8, the arrow keys' keydown events now have codes of the form
NumpadX
instead of the expectedArrow{Left,Right,...}
. Delete's also becameNumpadDecimal
. Not sure if this is unique to my system, but according to mdn, it's known to be problematic:I've also added bottom and right margins to the tag editor, as the focus outline was getting cut off there(split off into #4115)