Skip to content

Fix arrow keys not working in tag editor on qt 6.8 #4114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 25, 2025

Conversation

iamllama
Copy link
Contributor

@iamllama iamllama commented Jun 22, 2025

Fixes #3751

On windows and on qt 6.8, the arrow keys' keydown events now have codes of the form NumpadX instead of the expected Arrow{Left,Right,...}. Delete's also became NumpadDecimal. Not sure if this is unique to my system, but according to mdn, it's known to be problematic:

For example, the code returned is "KeyQ" for the Q key on a QWERTY layout keyboard, but the same code value also represents the ' key on Dvorak keyboards and the A key on AZERTY keyboards. That makes it impossible to use the value of code to determine what the name of the key is to users if they're not using an anticipated keyboard layout.

To determine what character corresponds with the key event, use the KeyboardEvent.key property instead.

I've also added bottom and right margins to the tag editor, as the focus outline was getting cut off there (split off into #4115)

@iamllama iamllama force-pushed the fix-tag-editor-windows-qt68 branch from f423d5b to 6bb0cb2 Compare June 22, 2025 02:13
@abdnh abdnh merged commit a73f150 into ankitects:main Jun 25, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard navigation broken in tag selector (Qt 6.8)
2 participants