Skip to content

feat: after a node moved, auto offset when it overlaps with other nodes #4625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

GaoFuhong
Copy link
Collaborator

@GaoFuhong GaoFuhong commented May 16, 2025

Description

After a node is moved, if it overlaps with other nodes, it will be automatically offset. The offset direction can also be specified (by default, no offset occurs).
auto_offset

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Enhancement (changes that improvement of current feature or performance)
  • Refactoring (changes that neither fixes a bug nor adds a feature)
  • Test Case (changes that add missing tests or correct existing tests)
  • Code style optimization (changes that do not affect the meaning of the code)
  • Docs (changes that only update documentation)
  • Chore (changes that don't modify src or test files)

Self Check before Merge

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@x6-bot x6-bot bot added pkg:x6 PR: unreviewed PR does not have any reviews. labels May 16, 2025
@x6-bot
Copy link
Contributor

x6-bot bot commented May 16, 2025

👋 @GaoFuhong

💖 Thanks for opening this pull request! 💖

Please follow the contributing guidelines. And we use semantic commit messages to streamline the release process.

Examples of commit messages with semantic prefixes:

  • fix: don't overwrite prevent_default if default wasn't prevented
  • feat: add graph.scale() method
  • docs: graph.getShortestPath is now available

Things that will help get your PR across the finish line:

  • Follow the TypeScript, JavaScript, CSS and React coding style.
  • Run npm run lint locally to catch formatting errors earlier.
  • Document any user-facing changes you've made.
  • Include tests when adding/changing behavior.
  • Include screenshots and animated GIFs whenever possible.

We get a lot of pull requests on this repo, so please be patient and we will get back to you as soon as we can.

@x6-bot x6-bot bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 16, 2025
@codecov-commenter
Copy link

codecov-commenter commented May 16, 2025

Codecov Report

❌ Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 10.33%. Comparing base (5ed602f) to head (ceaddb6).
⚠️ Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
packages/x6/src/view/node.ts 0.00% 11 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4625   +/-   ##
=======================================
  Coverage   10.33%   10.33%           
=======================================
  Files         180      180           
  Lines       10580    10580           
  Branches     2580     2580           
=======================================
  Hits         1093     1093           
  Misses       9398     9398           
  Partials       89       89           
Flag Coverage Δ
x6 10.33% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
packages/x6/src/graph/options.ts 17.64% <ø> (ø)
packages/x6/src/view/node.ts 2.26% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@x6-bot x6-bot bot added PR: reviewed-approved PR has reviewed and got Approve from everyone. and removed PR: unreviewed PR does not have any reviews. labels May 19, 2025
@hustcc
Copy link
Member

hustcc commented Jul 22, 2025

@GaoFuhong X6 有单测吗,如果有的话,给这个函数加一个单测?

@x6-bot x6-bot bot added PR: unreviewed PR does not have any reviews. and removed PR: reviewed-approved PR has reviewed and got Approve from everyone. labels Jul 22, 2025
@x6-bot x6-bot bot added PR: reviewed-approved PR has reviewed and got Approve from everyone. and removed PR: unreviewed PR does not have any reviews. labels Jul 22, 2025
@hustcc hustcc merged commit a036572 into master Jul 22, 2025
12 checks passed
@hustcc hustcc deleted the feat-node-auto-offset branch July 22, 2025 13:41
@x6-bot x6-bot bot added PR: merged PR has merged. and removed PR: reviewed-approved PR has reviewed and got Approve from everyone. labels Jul 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg:x6 PR: merged PR has merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants