JAVA-3148: Implementing OpenTelemetry for Observability #2021
+2,335
−533
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Andrew Tolbert <6889771+tolbertam@users.noreply.github.com>
…documentation, test
| } | ||
|
|
||
| @Nullable | ||
| private Field getProxyAddressField() { |
There was a problem hiding this comment.
We should not need to do that on our own code base. AFAIK, we should just add getter in SniEndPoint.
| public OtelRequestTracker(OpenTelemetry openTelemetry) { | ||
| this.tracer = | ||
| openTelemetry.getTracer("com.datastax.oss.driver.internal.core.tracker.OtelRequestTracker"); | ||
| this.threadPool = |
There was a problem hiding this comment.
I would add thread pool as optional constructor parameter. There are multiple parameters that may vary between applications.
| @NonNull Request request, | ||
| @NonNull DriverExecutionProfile executionProfile, | ||
| @NonNull String requestLogPrefix) { | ||
| Span parentSpan = tracer.spanBuilder("Cassandra Java Driver Session Request").startSpan(); |
There was a problem hiding this comment.
Not sure if we should not add .setParent(Context.current().with(Span.current())) to link potential parent context started by the application.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On top of #1949
We need to merge that one first before we merge this one.
Here is an example system using this branch. We should find a better place to put that project than under my name.