Skip to content

[fix](compile) fix some implicit type conversion issue #53972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

luwei16
Copy link
Contributor

@luwei16 luwei16 commented Jul 28, 2025

No description provided.

@hello-stephen
Copy link
Contributor

Thank you for your contribution to Apache Doris.
Don't know what should be done next? See How to process your PR.

Please clearly describe your PR:

  1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
  2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
  3. What features were added. Why was this function added?
  4. Which code was refactored and why was this part of the code refactored?
  5. Which functions were optimized and what is the difference before and after the optimization?

@luwei16
Copy link
Contributor Author

luwei16 commented Jul 28, 2025

run buildall

@luwei16
Copy link
Contributor Author

luwei16 commented Jul 28, 2025

run buildall

@github-actions github-actions bot added the approved Indicates a PR has been approved by one committer. label Jul 28, 2025
Copy link
Contributor

PR approved by at least one committer and no changes requested.

Copy link
Contributor

PR approved by anyone and no changes requested.

@doris-robot
Copy link

TPC-H: Total hot run time: 34611 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
Tpch sf100 test result on commit 1be6a00e7c0a343a04caab0e38c40bc4984e12e9, data reload: false

------ Round 1 ----------------------------------
q1	17573	5440	5420	5420
q2	1923	306	204	204
q3	10467	1332	718	718
q4	10248	983	528	528
q5	7991	2363	2370	2363
q6	187	168	132	132
q7	863	771	650	650
q8	9307	1306	1073	1073
q9	6830	5121	5062	5062
q10	6905	2379	1948	1948
q11	474	287	274	274
q12	361	363	230	230
q13	17797	3571	3152	3152
q14	229	256	215	215
q15	550	466	466	466
q16	433	446	390	390
q17	589	836	363	363
q18	7498	7285	7371	7285
q19	3078	1041	565	565
q20	585	315	224	224
q21	3408	3203	2332	2332
q22	1027	1061	1017	1017
Total cold run time: 108323 ms
Total hot run time: 34611 ms

----- Round 2, with runtime_filter_mode=off -----
q1	5567	5752	5314	5314
q2	363	305	216	216
q3	2148	2637	2264	2264
q4	1404	1737	1342	1342
q5	4599	4491	4496	4491
q6	226	183	136	136
q7	2031	1952	1782	1782
q8	2643	2602	2574	2574
q9	7343	7222	7386	7222
q10	3217	3349	2912	2912
q11	551	542	514	514
q12	735	801	648	648
q13	3647	3860	3342	3342
q14	467	353	274	274
q15	495	465	445	445
q16	437	474	445	445
q17	1156	1455	1374	1374
q18	7889	7776	7915	7776
q19	10196	985	1184	985
q20	2355	1884	1745	1745
q21	7985	4277	4465	4277
q22	1087	1017	982	982
Total cold run time: 66541 ms
Total hot run time: 51060 ms

@doris-robot
Copy link

TPC-DS: Total hot run time: 162724 ms
machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
TPC-DS sf100 test result on commit 1be6a00e7c0a343a04caab0e38c40bc4984e12e9, data reload: false

reason	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 22:43:56	2023-12-26 22:44:01	NULL	utf-8	NULL	NULL	
============================================
query1	998	424	413	413
query2	6526	1808	1689	1689
query3	6744	229	222	222
query4	26842	23912	22763	22763
query5	4400	634	540	540
query6	353	259	227	227
query7	4633	526	298	298
query8	283	250	236	236
query9	8576	2986	2984	2984
query10	468	326	293	293
query11	15415	15002	14809	14809
query12	186	135	130	130
query13	1667	565	407	407
query14	8795	6183	6050	6050
query15	215	201	178	178
query16	7490	623	487	487
query17	1252	801	647	647
query18	2159	457	336	336
query19	243	223	196	196
query20	151	157	137	137
query21	224	134	111	111
query22	4036	4148	3993	3993
query23	34401	34148	34217	34148
query24	7562	2443	2404	2404
query25	498	528	453	453
query26	726	298	168	168
query27	2379	503	359	359
query28	3045	2295	2275	2275
query29	649	605	529	529
query30	290	246	206	206
query31	899	782	742	742
query32	90	83	82	82
query33	539	427	395	395
query34	798	832	515	515
query35	809	815	800	800
query36	1012	1032	918	918
query37	136	109	95	95
query38	4010	4114	3971	3971
query39	1448	1388	1391	1388
query40	239	144	139	139
query41	63	61	56	56
query42	144	130	133	130
query43	498	511	498	498
query44	1391	883	895	883
query45	198	194	188	188
query46	941	1063	664	664
query47	1836	1860	1756	1756
query48	400	420	315	315
query49	665	511	426	426
query50	702	694	424	424
query51	5636	5592	5548	5548
query52	135	139	129	129
query53	260	296	214	214
query54	668	667	572	572
query55	95	95	89	89
query56	370	363	357	357
query57	1212	1232	1170	1170
query58	342	340	337	337
query59	2573	2577	2506	2506
query60	430	400	391	391
query61	126	130	144	130
query62	751	743	639	639
query63	288	214	221	214
query64	2381	1120	790	790
query65	4261	4105	4123	4105
query66	906	458	332	332
query67	query68	17600	637	596	596
query69	1003	334	297	297
query70	1413	1133	1153	1133
query71	717	351	333	333
query72	9179	2355	2359	2355
query73	3738	634	354	354
query74	8915	9069	8576	8576
query75	7701	3174	2723	2723
query76	8841	1220	792	792
query77	1151	415	345	345
query78	query79	17102	595	578	578
query80	1874	550	481	481
query81	554	269	238	238
query82	596	155	117	117
query83	332	289	275	275
query84	298	109	87	87
query85	1735	375	334	334
query86	360	314	308	308
query87	4372	4379	4385	4379
query88	5461	2295	2310	2295
query89	525	365	327	327
query90	2564	308	241	241
query91	155	141	114	114
query92	88	76	68	68
query93	7071	930	668	668
query94	1154	365	295	295
query95	435	332	329	329
query96	523	556	294	294
query97	2741	2732	2701	2701
query98	247	222	230	222
query99	1555	1309	1273	1273
Total cold run time: 298458 ms
Total hot run time: 162724 ms

@doris-robot
Copy link

BE UT Coverage Report

Increment line coverage 40.00% (8/20) 🎉

Increment coverage report
Complete coverage report

Category Coverage
Function Coverage 57.62% (15981/27736)
Line Coverage 46.38% (143730/309901)
Region Coverage 35.80% (108409/302860)
Branch Coverage 38.32% (47821/124782)

@hello-stephen
Copy link
Contributor

skip check_coverage

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by one committer. reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants