[SCM-530] Add support for git submodules to git SCM provider

[jira-importer]

Chas Emerick opened SCM-530 and commented

Pretty self-explanatory. Example fallout of this issue: release:perform on a project that refers to other git repos as submodules cannot succeed.

---

Affects: 1.3

Issue Links:

• SCM-844 Add support for git submodules to jgit SCM provider

Remote Links:

• GitHub Pull Request #179
  

7 votes, 12 watchers

[jira-importer]

Chas Emerick commented

FYI, Hudson's git plugin provides submodule capability, so looking at that impl might be worthwhile.

[jira-importer]

sital anadkat commented

Hi , I supplied a patch to use git submodules, please see the following link
http://jira.codehaus.org/browse/MRELEA[SE-726](https://issues.apache.org/jira/browse/SE-726)#comment-324432

[jira-importer]

Tomasz Krakowiak commented

I would like to implement support of submodules in git scm providers.
This is what I think it should be implemented (pseudocode):

checkin(repository, fileSet, options){
  gitmodules = listGitSubmodules();// Non-recursive
  for(gitmodule : gitmodules){
    moduleFileSet = narrowFileSetToModule(repository, gitmodule, fileset); // Returns subset of files narrowed
                                                                           // to those contained in module's directory.
                                                                           // (relative paths are resolved to absolute
                                                                           // paths or relative to module's directory)
    if(!isEmpty(moduleFileSet)){
      if(!isSubmoduleInitialized(repository, gitmodule)){
        return "Git submodule " + gitmodule + "is not initialized";
      }
      moduleRepository = submoduleRepository(repository, submodule);
      result = checkin(moduleRepository, moduleFileSet, options);
      if(!isSuccess(result)){
        return result;
      }
      fileSet.add(submodule);
    }
  }
  ... // Do the same thing as currently.
}

I'm only worried about using scm connection for submodules not configured in pom. Still everything should work as long everything is properly configured in git (i would not recommend providing submodule url overriding).

[jira-importer]

Tomasz Krakowiak commented

Probably recursive tagging option in scm and release plugins would also be nice. But if we would like to use different tag's in submodules it would require change in scm api.