Skip to content

Conversation

kwin
Copy link
Member

@kwin kwin commented Jul 28, 2025

Add SSH based push tag test
Refactor SSH support for tests

This closes #1253

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin kwin requested a review from michael-o July 28, 2025 14:36
@kwin kwin marked this pull request as draft July 28, 2025 15:02
@kwin kwin force-pushed the feature/pass-env-variables-to-git-tag-push branch 2 times, most recently from 4f2c0d4 to 391b806 Compare July 28, 2025 15:52
@kwin kwin changed the title Git: Use environment variables when pushing tags to remote Git: Use environment variables when pushing tags/branches to remote Jul 28, 2025
@kwin kwin force-pushed the feature/pass-env-variables-to-git-tag-push branch 6 times, most recently from 106fe3a to d792c82 Compare July 28, 2025 17:30
@kwin
Copy link
Member Author

kwin commented Jul 28, 2025

@michael-o Could I ask for your support to debug the Windows related test error? I currently fail to see where I missed to release a file handle.

@kwin kwin force-pushed the feature/pass-env-variables-to-git-tag-push branch from d792c82 to d6f3429 Compare July 29, 2025 07:06
Add SSH based push tag/branch tests
Refactor SSH support for tests

This closes #1253
@kwin kwin force-pushed the feature/pass-env-variables-to-git-tag-push branch from d6f3429 to b1a6f2b Compare July 29, 2025 13:30
@kwin
Copy link
Member Author

kwin commented Jul 29, 2025

The issue with testing on Windows (and undeletable directories) is caused by apache/mina-sshd#794.

@kwin kwin force-pushed the feature/pass-env-variables-to-git-tag-push branch from 1fc548c to c183b19 Compare July 29, 2025 14:23
apache/mina-sshd#794

Otherwise the repository won't be closed and Windows cannot remove the
repository directory
@kwin kwin force-pushed the feature/pass-env-variables-to-git-tag-push branch from f673f7c to ddf53b4 Compare July 29, 2025 18:09
@kwin kwin marked this pull request as ready for review July 29, 2025 19:21
@kwin kwin merged commit 6fc20f7 into master Jul 30, 2025
36 checks passed
@kwin kwin deleted the feature/pass-env-variables-to-git-tag-push branch July 30, 2025 10:55
@github-actions github-actions bot added this to the 2.1.1 milestone Jul 30, 2025
Copy link

@kwin Please assign appropriate label to PR according to the type of change.

@kwin kwin added the bug Something isn't working label Aug 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SCM-1030] Prepare goal does fail to push tag using SCM URL over SSH
1 participant