-
Notifications
You must be signed in to change notification settings - Fork 28.7k
[SPARK-52936][INFRA][TESTS] Benchmark result update automation #51643
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
git config --local user.email "${{ github.event.pusher.email || format('{0}@users.noreply.github.com', github.actor) }}" | ||
git add -A | ||
git commit -m "Benchmark results for ${{ inputs.class }} (JDK ${{ inputs.jdk }}, Scala ${{ inputs.scala }}, split ${{ matrix.split }} of ${{ inputs.num-splits }})" | ||
for i in {1..5}; do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is 5 a magic number? Why do we need this repetition?
type: boolean | ||
description: 'Commit the benchmark results to the current branch' | ||
required: true | ||
default: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for making this false
by default.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a nice improvement (if it works as expected).
I'm curious if it works correctly when the number of split is large like 50.
cc @peter-toth |
What changes were proposed in this pull request?
This PR adds automation for benchmark result update in PRs
Why are the changes needed?
Reduce costs and improve efficiency for benchmarking
Does this PR introduce any user-facing change?
no
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
no