[SPARK-52944][CORE][TESTS][FOLLOWUP] Avoid hard-coding the checksum algorithm name #51675
+3
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LuciferYang
commented
Jul 26, 2025
| @@ -70,7 +70,8 @@ class SortShuffleSuite extends ShuffleSuite with BeforeAndAfterAll { | |||
| // Ensure that the shuffle actually created files that will need to be cleaned up | |||
| val filesCreatedByShuffle = getAllFiles -- filesBeforeShuffle | |||
| filesCreatedByShuffle.map(_.getName) should be( | |||
| Set("shuffle_0_0_0.data", "shuffle_0_0_0.checksum.ADLER32", "shuffle_0_0_0.index")) | |||
| Set("shuffle_0_0_0.data", s"shuffle_0_0_0.checksum.${conf.get(SHUFFLE_CHECKSUM_ALGORITHM)}", | |||
There was a problem hiding this comment.
cc @dongjoon-hyun FYI
dongjoon-hyun
changed the title
dongjoon-hyun
approved these changes
Jul 27, 2025
|
Thanks @dongjoon-hyun |
|
After verification, I will also backport this PR to branch-4.0 to maintain consistency. |
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
Jul 27, 2025
…lgorithm name ### What changes were proposed in this pull request? This PR retrieves the shuffle checksum algorithm name via `conf.get(SHUFFLE_CHECKSUM_ALGORITHM)` to eliminate hard-coding. ### Why are the changes needed? Address apache#51654 (comment) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51675 from LuciferYang/SPARK-52944-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
LuciferYang
added a commit
to LuciferYang/spark
that referenced
this pull request
Jul 27, 2025
…lgorithm name ### What changes were proposed in this pull request? This PR retrieves the shuffle checksum algorithm name via `conf.get(SHUFFLE_CHECKSUM_ALGORITHM)` to eliminate hard-coding. ### Why are the changes needed? Address apache#51654 (comment) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes apache#51675 from LuciferYang/SPARK-52944-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org>
LuciferYang
added a commit
that referenced
this pull request
Jul 27, 2025
…lgorithm name ### What changes were proposed in this pull request? This PR retrieves the shuffle checksum algorithm name via `conf.get(SHUFFLE_CHECKSUM_ALGORITHM)` to eliminate hard-coding. ### Why are the changes needed? Address #51654 (comment) ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? - Pass Github Actions ### Was this patch authored or co-authored using generative AI tooling? No Closes #51675 from LuciferYang/SPARK-52944-FOLLOWUP. Authored-by: yangjie01 <yangjie01@baidu.com> Signed-off-by: Dongjoon Hyun <dongjoon@apache.org> (cherry picked from commit afd595a) Signed-off-by: yangjie01 <yangjie01@baidu.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR retrieves the shuffle checksum algorithm name via
conf.get(SHUFFLE_CHECKSUM_ALGORITHM)to eliminate hard-coding.Why are the changes needed?
Address #51654 (comment)
Does this PR introduce any user-facing change?
No
How was this patch tested?
Was this patch authored or co-authored using generative AI tooling?
No