-
Notifications
You must be signed in to change notification settings - Fork 37
Make HeScheme context flexible #212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5a71a0a
to
28c8e83
Compare
Introduction of |
SGTM; faa9a32 has the delta. |
bf26507
to
5ac4035
Compare
5ac4035
to
2cc800e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removing Scheme
from Context required a lot of extra type annotations. Now that we put the scheme back into context. Those type annotations are not needed, and I would rather like to keep the change small and revert unnecessary changes.
This works: public static func multiplyInverseTest<Context: HeContext>(context: Context) async throws where Context.Scheme.Context == Context { Note, the more natural public static func multiplyInverseTest<Scheme: HeScheme>(context: Scheme.Context) async throws { fails due to We previously had public static func multiplyInverseTest<Scheme: HeScheme>(context: Context<Scheme>) async throws { but that constrains use of the function to schemes for which |
7e9e7a4
to
9a0cfaa
Compare
9a0cfaa
to
0d428eb
Compare
c61891b
to
b13680b
Compare
b13680b
to
99b939e
Compare
Make
HeContext
protocol, which different HE schemes can implement.