Pamribeirox patch 1 #23671
Open
Pamribeirox patch 1 #23671
+54
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in Veml6070Detect check for the presence of both addresses in the bus to avoid misdetection of ATH20/21 (anyone with the device, please confirm this change still detect the device when present)
check the correct ID was returned to avoid misdetection of other sensors.
Add the raw infrared and broadband channels of the sensor to the JSON report like is done in the driver for TSL2561
Update xsns_57_tsl2591.ino - report channel values in JSON as in TSL2561
Fix var name
Fix variable name
Pamribeirox patch 1
Add an AGC logic to update the gain of the sensors in case o saturation or low value read. Add the gain information to the JSON report to give some meaning to the sensor raw values.
|
Without any description and checking the boxes the PR will be closed automatically from the bot. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue (if applicable): fixes #
Checklist:
NOTE: The code change must pass CI tests. Your PR cannot be merged unless tests pass