Skip to content

add tests #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 19, 2025
Merged

add tests #1

merged 5 commits into from
Jul 19, 2025

Conversation

nedbat
Copy link

@nedbat nedbat commented Jul 13, 2025

Here is a test, though there are two problems:

  1. it hangs forever on ubuntu in CI. I don't understand all the dynamics here with subprocesses, so it's hard to debug.
  2. I wanted to check the output from communicate, but it comes out as an empty bytestring.

Also, there are some refactoring commits here that are already on master.

@nedbat nedbat force-pushed the nedbat/more-1998 branch 6 times, most recently from 42cb985 to 9379af8 Compare July 13, 2025 22:10
@nedbat nedbat mentioned this pull request Jul 13, 2025
Closed
@nedbat nedbat force-pushed the nedbat/more-1998 branch 4 times, most recently from dd26c87 to cce282d Compare July 15, 2025 12:02
@nedbat nedbat force-pushed the nedbat/more-1998 branch from cce282d to a89c789 Compare July 15, 2025 12:05
@nedbat
Copy link
Author

nedbat commented Jul 15, 2025

These tests now pass.

ark-g
ark-g reviewed Jul 17, 2025
View reviewed changes
@ark-g ark-g merged commit 3f8ef2f into ark-g:master Jul 19, 2025
@nedbat nedbat deleted the nedbat/more-1998 branch July 19, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ark-g ark-g ark-g approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nedbat @ark-g