-
Notifications
You must be signed in to change notification settings - Fork 4.2k
feat(kinesisfirehose): support S3 file extension format #33776
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #33776 +/- ##
=======================================
Coverage 82.39% 82.39%
=======================================
Files 120 120
Lines 6960 6960
Branches 1175 1175
=======================================
Hits 5735 5735
Misses 1120 1120
Partials 105 105
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
@Mergifyio update |
☑️ Nothing to do
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32154.
Reason for this change
The file extension can be overridden by specifying
FileExtension
.For details, see S3 file extension format (optional) in Configure destination settings for Amazon S3
Description of changes
Added
fileExtension
prop toS3BucketProps
.Describe any new or updated permissions being added
N/A
Description of how you validated changes
Added unit tests and updated an integ test to include
fileExtension
.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license