Fix denylisting x-amz-user-agent in SignatureV4 #2882
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When checking headers for signature inclusion, they are lowercased, thus `X-Amz-User-Agent` is never skipped from signature, even though it is blacklisted exactly like that.
|
@stobrien89 @yenfryherrerafeliz could you guys have a look at this, please? |
yenfryherrerafeliz
changed the title
yenfryherrerafeliz
approved these changes
Jul 29, 2024
GrahamCampbell
approved these changes
Apr 28, 2025
This was referenced May 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When checking headers for signature inclusion, they are lowercased, thus
X-Amz-User-Agentis never skipped from signature, even though it is blacklisted exactly like that.Description of changes:
X-Amz-User-Agent turned to lowercase in blacklist, as all checks with blacklist are with lowercased headers.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.