This repository was archived by the owner on Mar 19, 2025. It is now read-only.
default service option in config #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also added analytics (I didn't branch properly so it is in the same PR but both fairly minor config changes) |
|
Cool, thanks. |
sadleb
added a commit
that referenced
this pull request
Oct 3, 2014
default service option in config
sadleb
pushed a commit
that referenced
this pull request
Jul 15, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Like the comment says, this really shouldn't happen, and I noted in asana that following the regular flow, even if the param isn't in the url, it is OK, that data isn't lost, but this PR gives a solution just in case someone goes outside the normal flow.
The service url needs to be the one that would be passed. https://stagingportal.beyondz.org/login/cas for Canvas and https://staging.beyondz.org/users/service for the main site (which can redirect to canvas - I recommend using the main site as a default).