Resolve pubsub future only when nothing can happen anymore #72
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dippi
commented
Jul 4, 2021
| .unwrap(); | ||
| } | ||
| return Err(error::Error::Connection(ConnectionReason::NotConnected)); | ||
| // This can only happen if the connection is closed server-side |
There was a problem hiding this comment.
Here I removed the handling of the special case, because I couldn't think of a reason to keep it. Am I missing anything?
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn test_connection_is_closed_after_channel_is_dropped() { |
There was a problem hiding this comment.
I had to do this test outside the test module, to have access to the private types. Is there a better way?
|
Any chance this PR could be accepted ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes
PubsubConnectionInnershould complete only if everyPubsubConnectionhave been dropped.It should be enough to guarantee that:
PubsubStreamkeeps a reference toPubsubConnectionand unsubscribes when dropped)PubsubConnection)PubsubConnectionto do that)Fixes #50