Skip to content

enable scrolling inside of iframes #919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

seanmcguire12
Copy link
Member

why

  • currently, the scrolling functionality that exists inside performPlaywrightMethod calls page.evaluate
  • this means that scrolling can only ever happen at the page level, not inside of iframes
  • inside each of these scroll related helpers, we already have access to a chained locator that optionally points to an element inside an iframe
  • therefore, we should use this chained locator, and call locator.evaluate

what changed

  • scrollToNextChunk, scrollToPreviousChunk, scrollElementToPercentage all use locator.evaluate instead of page.evaluate which enables scrolling inside (and outside) of iframes

test plan

  • act evals

to do

  • add iframe scrolling evals

Copy link

changeset-bot bot commented Jul 26, 2025

🦋 Changeset detected

Latest commit: 0d329a8

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant