-
Notifications
You must be signed in to change notification settings - Fork 257
Convert @bugsnag/plugin-node-in-project to TypeScript #2506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: integration/typescript-node
Are you sure you want to change the base?
Convert @bugsnag/plugin-node-in-project to TypeScript #2506
Conversation
In test file we have
|
}, | ||
"devDependencies": { | ||
"@bugsnag/core": "^8.4.0", | ||
"@types/node": "^18.19.74" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
did we add this dev dependency in another package? if so, we should be able to just specify it once in the root package
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, actually I'm adding it in all packages. 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I checked, and we do have it in root package.json
:
"overrides": {
"@types/node": "^18",
}
So I delete it and re-run the build. Will do the same with the rest PRs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No problem with expecting errors in unit tests - looks good to me, just a note on a dev dependency
Goal
Convert @bugsnag/plugin-node-in-project to TypeScript
Design
Publish ES modules and convert Node packages to TypeScript
Changeset
Refactor @bugsnag/plugin-node-in-project package
Testing
Covered by existing end to end and unit tests