mpv: allow customizing background-color

[nghialm269]

Hi, thanks for the amazing work on this.

When playing 16:9 video in a 16:10 monitor, the top and bottom will be filled with background-color. It looks out of place, especially if there are black frames (transition) in the video, so I want to change/reset it to black.

Is it possible to allow customizing the background-color?

[getchoo]

I believe you can override this with programs.mpv.config.background-color, and that will take precedent over files that are imported

I don't really use MPV directly though so I could totally be wrong 😆

[nghialm269]

It doesn't work for me unfortunately.

I also tried to manually edit mpv.conf to move the background-color line to before/after the catppuccin's include line, but mpv doesn't pick it up. It works when I remove the include line though.

[different-name]

It doesn't work for me unfortunately.

I also tried to manually edit mpv.conf to move the background-color line to before/after the catppuccin's include line, but mpv doesn't pick it up. It works when I remove the include line though.

I tried this, got the same result

Honestly, I don't notice that Catppuccin mpv theme do anything but set the background-color for me, but maybe I am missing something

You could always disable the theme and do something like this instead

programs.mpv = {
  enable = true;
  config =
    let
      inherit (config.catppuccin) sources mpv;
      catppuccinTheme = builtins.readFile "${sources.mpv}/${mpv.flavor}/${mpv.accent}.conf";
      finalTheme =
        lib.replaceString "background-color='#1e1e2e'" "background-color='#000000'"
          catppuccinTheme;
    in
    {
      include = builtins.toFile "mpv-theme.conf" finalTheme;
    };
};

But also, maybe the mpv module should be parsing the toml instead of using include, as it seems only one include is allowed to be used (through the home-manager module at least)

[nghialm269]

Honestly, I don't notice that Catppuccin mpv theme do anything but set the background-color for me, but maybe I am missing something

You could try to install uosc UI plugin, the catppuccin/mpv theme support it well.

[isabelroses]

It doesn't work for me unfortunately.
I also tried to manually edit mpv.conf to move the background-color line to before/after the catppuccin's include line, but mpv doesn't pick it up. It works when I remove the include line though.

I tried this, got the same result

Honestly, I don't notice that Catppuccin mpv theme do anything but set the background-color for me, but maybe I am missing something

You could always disable the theme and do something like this instead

programs.mpv = {
enable = true;
config =
let
inherit (config.catppuccin) sources mpv;
catppuccinTheme = builtins.readFile "${sources.mpv}/${mpv.flavor}/${mpv.accent}.conf";
finalTheme =
lib.replaceString "background-color='#1e1e2e'" "background-color='#000000'"
catppuccinTheme;
in
{
include = builtins.toFile "mpv-theme.conf" finalTheme;
};
};
But also, maybe the mpv module should be parsing the toml instead of using include, as it seems only one include is allowed to be used (through the home-manager module at least)

This would be introduce IFD into the mpv module. So if you wanted to avoid that you should instead do.

{ pkgs, config, ... }:
let
  mpv = config.catppuccin.mpv;
in
{
  catppuccin.sources.mpv = inputs.catppuccin.${pkgs.system}.mpv.overrideAttrs (oldAttrs: {
    postPatch = (oldAttrs.postPach or "") + ''
      substituteInPlace "${mpv.flavor}/${mpv.accent}.conf" \
        --replace-fail "background-color='#1e1e2e'" "background-color='#000000'"
    '';
  })
}