Skip to content

Build fixes for Windows / Visual Studio #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Build fixes for Windows / Visual Studio #7

wants to merge 1 commit into from

Conversation

aras-p
Copy link

@aras-p aras-p commented Jan 22, 2023

  • popcount() implementations
  • workaround the lack of std::aligned_alloc
  • fix cpu_coded.inl wrongly using #ifdef instead of #if for OpenMP flags (the flag is defined, just to zero). With OpenMP this does not yet compile on MSVC out of the box.
  • cmake: when using MSVC, indicate C++ 20 (for to_string), do not pass gcc/clang warning flags, and build as static library since public symbols do not have "please export me" attributes set on them.

@aras-p
Build fixes for Windows / Visual Studio
9dc7b15 
- popcount() implementations
- workaround the lack of std::aligned_alloc
- fix cpu_coded.inl wrongly using #ifdef instead of #if for OpenMP
  flags (the flag is defined, just to zero). With OpenMP this does
  not yet compile on MSVC out of the box.
- cmake: when using MSVC, indicate C++ 20 (for to_string), do not pass
  gcc/clang warning flags, and build as static library since public
  symbols do not have "please export me" attributes set on them.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@aras-p