Skip to content

Define new conjunctivitis signal in google-symptoms #2112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jan 29, 2025

Conversation

nmdefries
Copy link
Contributor

@nmdefries nmdefries commented Jan 28, 2025

Description

Add new s07 signal to google-symptoms to track novel eye-related symptoms of H5N1.

Changelog

  • Add new composite definition in constants.py
  • Add to smoothed validator checks by adding new signal name to params templates.

Associated Issue(s)

Addresses #2097

@nmdefries nmdefries requested a review from aysim319 January 28, 2025 22:22
@nmdefries
Copy link
Contributor Author

nmdefries commented Jan 28, 2025

We will need to patch this in back to the beginning of google-symptoms history.

@aysim319
Copy link
Contributor

test data also needs to be updated to reflect the new signal

Copy link
Contributor

@aysim319 aysim319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running and I remember I kept the behavior of doing a full backfill on a regular run from previous code and it has potential cause some issues (would take multiple hours) and also would mess up the issue dates

Copy link
Contributor

@aysim319 aysim319 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried running and I remember I kept the behavior of doing a full backfill on a regular run from previous code and it has potential cause some issues (would take multiple hours) and also would mess up the issue dates

I can change the logic so it only logs and continues do the normal runs only. thoughts?

@nmdefries nmdefries merged commit 51620ea into main Jan 29, 2025
17 checks passed
@nmdefries nmdefries deleted the ndefries/gs-conjunctivitis branch January 29, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants