refactor: clean-up unused imports & fix types errors #100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Removed the console log statement for 'data' in the useAppConfig hook to clean up the code and improve performance.
- Removed commented-out PostHogProvider and related code to streamline the index.tsx file. - Ensured the StrictMode wrapper is correctly applied around the QueryClientProvider and application components for better performance and debugging.
- Removed unnecessary comment from the import statement for useAppConfig to improve code clarity.
- Updated the handleOnScrollChange function to remove unnecessary parameters, enhancing code clarity and maintainability.
- Added `@types/react` and `@types/react-dom` as devDependencies in package.json for improved TypeScript support. - Updated yarn.lock to include the new type definitions and their dependencies.
… overrides - Eliminated hover background color styles for the dropdown menu button in the _excalidraw-overrides.scss file to streamline the CSS and improve maintainability.
- Removed unnecessary comment from AuthDialog.scss to streamline the styles. - Changed the type of `warningText` prop in AuthDialog from string to React.ReactNode for better flexibility in rendering content.
- Moved the import statements for AccountDialog and MainMenu.scss to improve code organization. - Added spacing for better readability in the MainMenu.tsx file.
- Introduced a new _defaults.scss file to define CSS variables for slider and range track styles. - Updated index.scss to include the new defaults for improved styling consistency across components.
- Eliminated default CSS variables for slider and range track styles from Range.scss to streamline the styling process. - Added appearance property to the range input for improved cross-browser compatibility.
- Removed unused useState import from TabContextMenu.tsx to enhance code clarity and reduce unnecessary dependencies.
- Updated the ref assignment for tab titles to use a block statement for better readability and consistency in the Tabs.tsx file.
- Updated the type casting for user_id in the Collab component to ensure proper type handling of SocketId, improving code reliability and clarity.
- Removed unused state and handlers related to the SettingsDialog in App.tsx to streamline the component. - Added state management and conditional rendering for SettingsDialog in MainMenu.tsx, enhancing user experience and functionality.
- Added UserSettings interface in a new types.ts file to define user settings structure. - Introduced DEFAULT_SETTINGS constant in constants.ts for default user settings. - Updated imports in SettingsDialog and canvas files to reference the new constants and types, enhancing code organization and type safety.
…code - Removed commented-out imports, state, and handlers related to SettingsDialog in App.tsx to streamline the component and improve code clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This refactor is a frontend-wide clean up of unused imports, useless comments and types errors that were left over after #97