Skip to content

fix deadlog in Coverlet.Integration.Tests.BaseTest #1541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 11, 2023
Merged

fix deadlog in Coverlet.Integration.Tests.BaseTest #1541

merged 5 commits into from
Oct 11, 2023

Conversation

Bertk
Copy link
Collaborator

@Bertk Bertk commented Oct 10, 2023 •
edited
Loading

  • avoid deadlocks, use an asynchronous read operation on at least one of the streams (Process.StandardOutput + Process.StandaradError)
  • use project names for test artifacts (trx, html)
  • use CopyFiles instead of powershell script (publish-coverlet-result-files.yml)
  • disable CPM for coverlet.core.tests.csproj (VS reports "restore loop")

@Bertk Bertk marked this pull request as ready for review October 10, 2023 10:50
daveMueller
daveMueller approved these changes Oct 11, 2023
View reviewed changes
Copy link
Collaborator

@daveMueller daveMueller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All cool, LGTM 👍

@daveMueller daveMueller merged commit 89f2f3e into coverlet-coverage:master Oct 11, 2023
@Bertk Bertk deleted the fix-test-deadlock branch October 11, 2023 07:18
@Bertk Bertk changed the title fix deadlog in BaseTest fix deadlog in Coverlet.Integration.Tests.BaseTest Oct 12, 2023
This was referenced Jul 29, 2025
Closed
Open
Open
Closed
Closed
Open
Closed
Open
Open
Closed
Merged
Closed
Closed
Closed
Open
Merged
Open
Closed
Closed
Open
This was referenced Aug 19, 2025
Open
Open
Open
Open
Merged
CurtHagenlocher pushed a commit to apache/arrow-adbc that referenced this pull request Aug 19, 2025
@dependabot
chore(csharp): Bump coverlet.collector from 6.0.0 to 6.0.4 (#3314)
83d2bdf 
Updated
[coverlet.collector](https://github.com/coverlet-coverage/coverlet) from
6.0.0 to 6.0.4.

<details>
<summary>Release notes</summary>

_Sourced from [coverlet.collector's
releases](https://github.com/coverlet-coverage/coverlet/releases)._

## 6.0.4

### Fixed
- Fix empty coverage report when using include and exclude filters
[#​1726](coverlet-coverage/coverlet#1726)

[Diff between 6.0.3 and
6.0.4](coverlet-coverage/coverlet@v6.0.3...v6.0.4)

## 6.0.3

### Fixed
- Fix RuntimeConfigurationReader to support self-contained builds
[#​1705](coverlet-coverage/coverlet#1705) by
https://github.com/pfeigl
- Fix inconsistent filenames with UseSourceLink after .NET 8
[#​1679](coverlet-coverage/coverlet#1679)
- Fix hanging tests
[#​989](coverlet-coverage/coverlet#989)
- Fix coverlet instrumentation becomes slow after installing dotnet sdk
8.0.200
[#​1620](coverlet-coverage/coverlet#1620)
- Fix upgrading v6.0.1 to v6.0.2 increases instrumentation time
[#​1649](coverlet-coverage/coverlet#1649)
- Fix Unable to instrument module - NET 8
[#​1631](coverlet-coverage/coverlet#1631)
- Fix slow modules filtering process
[#​1646](coverlet-coverage/coverlet#1646) by
https://github.com/BlackGad
- Fix incorrect coverage await using in generic method
[#​1490](coverlet-coverage/coverlet#1490)

### Improvements
- Cache the regex used in InstrumentationHelper
[#​1693](coverlet-coverage/coverlet#1693)
- Enable dotnetTool integration tests for linux
[#​660](coverlet-coverage/coverlet#660)

[Diff between 6.0.2 and
6.0.3](coverlet-coverage/coverlet@v6.0.2...v6.0.3)

## 6.0.2

### Fixed
- Threshold-stat triggers error
[#​1634](coverlet-coverage/coverlet#1634)
- Fixed coverlet collector 6.0.1 requires dotnet sdk 8
[#​1625](coverlet-coverage/coverlet#1625)
- Type initializer errors after updating from 6.0.0 to 6.0.1
[#​1629](coverlet-coverage/coverlet#1629)
- Exception when multiple exclude-by-attribute filters specified
[#​1624](coverlet-coverage/coverlet#1624)

### Improvements
- More concise options to specify multiple parameters in
coverlet.console
[#​1624](coverlet-coverage/coverlet#1624)

[Diff between 6.0.1 and
6.0.2](coverlet-coverage/coverlet@v6.0.1...v6.0.2)

## 6.0.1

### Fixed
- Uncovered lines in .NET 8 for inheriting records
[#​1555](coverlet-coverage/coverlet#1555)
- Fix record constructors not covered when SkipAutoProps is true
[#​1561](coverlet-coverage/coverlet#1561)
- Fix .NET 7 Method Group branch coverage issue
[#​1447](coverlet-coverage/coverlet#1447)
- Fix ExcludeFromCodeCoverage does not exclude method in a partial class
[#​1548](coverlet-coverage/coverlet#1548)
- Fix ExcludeFromCodeCoverage does not exclude F# task
[#​1547](coverlet-coverage/coverlet#1547)
- Fix issues where ExcludeFromCodeCoverage ignored
[#​1431](coverlet-coverage/coverlet#1431)
- Fix issues with ExcludeFromCodeCoverage attribute
[#​1484](coverlet-coverage/coverlet#1484)
- Fix broken links in documentation
[#​1514](coverlet-coverage/coverlet#1514)
- Fix problem with coverage for .net5 WPF application
[#​1221](coverlet-coverage/coverlet#1221) by
https://github.com/lg2de
- Fix unable to instrument module for Microsoft.AspNetCore.Mvc.Razor
[#​1459](coverlet-coverage/coverlet#1459) by
https://github.com/lg2de

### Improvements
- Extended exclude by attribute feature to work with fully qualified
name [#​1589](coverlet-coverage/coverlet#1589)
- Use System.CommandLine instead of McMaster.Extensions.CommandLineUtils
[#​1474](coverlet-coverage/coverlet#1474) by
https://github.com/Bertk
- Fix deadlog in Coverlet.Integration.Tests.BaseTest
[#​1541](coverlet-coverage/coverlet#1541) by
https://github.com/Bertk
- Add coverlet.msbuild.tasks unit tests
[#​1534](coverlet-coverage/coverlet#1534) by
https://github.com/Bertk

[Diff between 6.0.0 and
6.0.1](coverlet-coverage/coverlet@v6.0.0...v6.0.1)

Commits viewable in [compare
view](coverlet-coverage/coverlet@v6.0.0...v6.0.4).
</details>

[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=coverlet.collector&package-manager=nuget&previous-version=6.0.0&new-version=6.0.4)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This was referenced Aug 19, 2025
Open
Open
Open
Open
Open
Open
Open
Open
Closed
Open
Closed
Closed
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daveMueller daveMueller daveMueller approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Bertk @daveMueller