WLCG tape API: do not report empty fields in json responses #7875
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation ---------- Commit 36d6a5e added reporting null and default value fields. Turns out FTS (CERN File Transfer Service), when it processes REST API Reponse checks the "error" field and considers request failed if the field is present (ignoring that it has null value) Modification ------------ Annotate classes used by WCLG tape API w/ @JsonInclude(JsonInclude.Include.NON_NULL) to skip null fields only for WCLC tape rest api Result ------ No null error is reported Acked-by: Chris Green Patch: https://rb.dcache.org/r/14512/ Target: trunk Request: 11.x, 10.x, 9.x Require-book: no Require-notes: yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Commit 36d6a5e added reporting null and default value fields. Turns out FTS (CERN File Transfer Service), when it processes REST API Reponse checks the "error" field
and considers request failed if the field is present (ignoring that it has null value)
Modification
Annotate classes used by WCLG tape API w/
@JsonInclude(JsonInclude.Include.NON_NULL)
to skip null fields only for WCLC tape rest api
Result
No null error is reported
Acked-by: Chris Green
Patch: https://rb.dcache.org/r/14512/
Target: trunk
Request: 11.x, 10.x, 9.x
Require-book: no
Require-notes: yes