Gas+rad+rec EoS: Include changes in effective gamma due to H2 vibrational and rotational modes #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gy when do_radiation=true
… that ionisation physics can be used with radiation
… rapid_dtanh with elemental functions
…l inflection point
themikelau
commented
May 2, 2025
| @@ -326,10 +323,10 @@ subroutine get_rhoT_grid(npts,rhogrid,Tgrid) | |||
|
|
|||
| ! Initialise grids in Q and T (cgs units) | |||
| npts = 30 | |||
| logQmin = -10. | |||
There was a problem hiding this comment.
Check how much I can increase the Q and T range.
|
New issue identified: The runtime options X and Z appear twice, once to specify the composition for the gas+rad+rec EoS, and once for the radiation module to specify the composition for the MESA opacity tables. Should enforce having the opacity composition follow the EoS composition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft
Relevant for #487