Fix AttributeError in LRU cache eviction (missing query on Node) #1124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ci:2://file:///c:/Users/T2430514/Downloads/system-design-primer/solutions/object_oriented_design/lru_cache/lru_cache.py:0:0-4:24)) The sample LRU cache crashes on eviction because [Node](cci:2://file:///c:/Users/T2430514/Downloads/system-design-primer/solutions/object_oriented_design/lru_cache/lru_cache.py:0:0-4:24) instances lack a `query` attribute, yet `Cache.set()` references `tail.query` when removing the oldest item. Added `query` (and minor docs) to [Node](cci:2://file:///c:/Users/T2430514/Downloads/system-design-primer/solutions/object_oriented_design/lru_cache/lru_cache.py:0:0-4:24) and create nodes with both key and value, eliminating the runtime error and restoring cache functionality. Co-Authored-By: S. M. Mohiuddin Khan Shiam <147746955+mohiuddin-khan-shiam@users.noreply.github.com>
The sample LRU cache crashes on eviction because Node instances lack a query attribute, yet Cache.set() references tail.query when removing the oldest item. Added query (and minor docs) to Node and create nodes with both key and value, eliminating the runtime error and restoring cache functionality.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix AttributeError in LRU cache eviction (missing
queryon Node)Description
The sample LRU cache crashes on eviction because Node instances lack a
queryattribute, yetCache.set()referencestail.querywhen removing theoldest item.
Added
query(and minor docs) to Node and create nodes with both key andvalue, eliminating the runtime error and restoring cache functionality.