Skip to content
This repository was archived by the owner on Jun 24, 2022. It is now read-only.

Configurable jvm.options.j2 template path #400

Closed
wants to merge 3 commits into from
Closed

Configurable jvm.options.j2 template path #400

wants to merge 3 commits into from

Conversation

andreausu
Copy link

@andreausu andreausu commented Nov 27, 2017

No description provided.

Copy link
Contributor

@Crazybus Crazybus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! I left one small comment.

Would it also be possible to rebase your branch against master? Then i can run all of the automated testing to make sure this doesn't break anything.

@@ -27,8 +27,9 @@
es_heap_size: 1g
#add a custom log4j file
es_config_log4j2: "./files/logging/log4j2.properties.custom.j2"
es_config_jvmoptionsj2: "./files/jvm/jvm.options.custom.j2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this template is being used for testing and is just a copy of templates/jvm.options.j2 could you please move it to test/integration/config/templates/jvm.options.custom.j2

@karmi
Copy link

karmi commented Mar 13, 2018

Hi @andreausu, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile?

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@andreausu
Copy link
Author

@Crazybus done, thanks

@Crazybus
Copy link
Contributor

jenkins test this please

@FreakyGranny
Copy link

Very useful feature, we need it, too.

@elasticmachine
Copy link
Collaborator

Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually?

@Crazybus
Copy link
Contributor

jenkins test this please

@jmlrt jmlrt added the feature label Sep 17, 2019
@botelastic
Copy link

botelastic bot commented Sep 18, 2019

This PR has been automatically marked as stale because it has not had
recent activity. It will be closed if no further activity occurs. Thank you
for your contributions.
To track this PR (even if closed), please open a corresponding issue if one does not already exist.

@botelastic
Copy link

botelastic bot commented Oct 18, 2019

This PR has been automatically closed because it has not had recent activity since being marked as stale.
Please reopen when work resumes.

@botelastic botelastic bot closed this Oct 18, 2019
@jmlrt jmlrt mentioned this pull request Nov 27, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants