-
Notifications
You must be signed in to change notification settings - Fork 853
Configurable jvm.options.j2 template path #400
Configurable jvm.options.j2 template path #400
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff! I left one small comment.
Would it also be possible to rebase your branch against master? Then i can run all of the automated testing to make sure this doesn't break anything.
test/integration/config.yml
Outdated
@@ -27,8 +27,9 @@ | |||
es_heap_size: 1g | |||
#add a custom log4j file | |||
es_config_log4j2: "./files/logging/log4j2.properties.custom.j2" | |||
es_config_jvmoptionsj2: "./files/jvm/jvm.options.custom.j2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this template is being used for testing and is just a copy of templates/jvm.options.j2
could you please move it to test/integration/config/templates/jvm.options.custom.j2
Hi @andreausu, we have found your signature in our records, but it seems like you have signed with a different e-mail than the one used in yout Git commit. Can you please add both of these e-mails into your Github profile (they can be hidden), so we can match your e-mails to your Github profile? |
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
@Crazybus done, thanks |
jenkins test this please |
Very useful feature, we need it, too. |
Since this is a community submitted pull request, a Jenkins build has not been kicked off automatically. Can an Elastic organization member please verify the contents of this patch and then kick off a build manually? |
jenkins test this please |
This PR has been automatically marked as stale because it has not had |
This PR has been automatically closed because it has not had recent activity since being marked as stale. |
No description provided.