Skip to content

Clarify support of Podman #42303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

lucabelluccini
Copy link
Contributor

@lucabelluccini lucabelluccini commented Jan 13, 2025

  • Docs

Proposed commit message

Clarify support of Podman with the Docker module

This change should be backported to 8.16 and 8.17 branches.

We need to add a similar message to the integrations docs https://www.elastic.co/guide/en/integrations/current/docker.html#docker-compatibility

@lucabelluccini lucabelluccini requested a review from a team as a code owner January 13, 2025 19:15
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 13, 2025
@botelastic
Copy link

botelastic bot commented Jan 13, 2025

This pull request doesn't have a Team:<team> label.

Copy link
Contributor

mergify bot commented Jan 13, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @lucabelluccini? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 13, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 13, 2025
@lucabelluccini lucabelluccini added backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify labels Jan 13, 2025
@belimawr
Copy link
Contributor

@lucabelluccini running mage update on metricbeat will generate the missing files and get CI green

cd metricbeat
mage update

@lucabelluccini
Copy link
Contributor Author

Thanks @belimawr

Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, we don't maintain/update AsciiDoc documentation anymore. Please make the change here instead https://github.com/elastic/beats/tree/main/docs/reference/metricbeat

The new contribution guide can be found here https://staging-website.elastic.co/docs/extend/beats/contributing-docs

Copy link
Contributor

mergify bot commented Apr 11, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b docs-podman-update-docs upstream/docs-podman-update-docs
git merge upstream/main
git push upstream docs-podman-update-docs

@rdner
Copy link
Member

rdner commented Apr 11, 2025

If we want this to be in 8.x releases, we might want to re-use this PR for the 8.x branch and open a new one for main.

@lucabelluccini
Copy link
Contributor Author

Can this PR be taken over by ingest-docs?

@pierrehilbert
Copy link
Collaborator

cc @kilfoyle

@kilfoyle
Copy link
Contributor

Can this PR be taken over by ingest-docs?

Sure! I've opened up:

@kilfoyle
Copy link
Contributor

@lucabelluccini I think this PR can be closed since the backports have all been merged now.

@kilfoyle kilfoyle closed this Apr 16, 2025
@lucabelluccini
Copy link
Contributor Author

Thank you @kilfoyle for taking care of this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify backport-8.16 Automated backport with mergify backport-8.17 Automated backport with mergify needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants