capture extra vsphere metrics (cpu %, disk average, disk rate, disk n…

[stefans-elastic]

…umber, memory usage %)

Proposed commit message

Checklist

• My code follows the style guidelines of this project
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have made corresponding change to the default configuration files
• I have added tests that prove my fix is effective or that my feature works
• I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

• [ ]

How to test this PR locally

Related issues

• Closes Beats. vSphere metrics to be added #44325

Use cases

Screenshots

Using vcsim simulation of vSphere API not all metrics were available to check (it appears that vcsim doesn't generate disk usage metrics).
So only 2 of the new metrics were generated by vsim (cpu.percent and memory.percent):

However when I tried commenting out the check if a metric is in list of "available" metrics in the code (line 70 in metricbeat/module/vsphere/client/performance.go) it showed more metrics:

So only disk.numberWrite and disk.numberRead I wasn't able to test at all.

Logs

[mergify]

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @stefans-elastic? 🙏.
For such, you'll need to label your PR with:

• The upcoming major version of the Elastic Stack
• The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

• backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
• backport-active-all is the label that automatically backports to all active branches.
• backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
• backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

[mergify]

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b vsphere-metrics upstream/vsphere-metrics
git merge upstream/main
git push upstream vsphere-metrics

[ishleenk17]

@stefans-elastic
Since, we have moved the perf manager code to a common place (good step).
I hope we have tested the metrics of host and datastore that were using the previous implementation.

[stefans-elastic]

@stefans-elastic Since, we have moved the perf manager code to a common place (good step). I hope we have tested the metrics of host and datastore that were using the previous implementation.

I've just tried it again and host and datastore streams appear to be working fine. Here are screenshots with some of the properties:

[ishleenk17]

Thank you for addressing all the comments.
GTG!