Skip to content

Fix default scan_frequency to 60s #44304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

Conversation

kaiyan-sheng
Copy link
Contributor

Proposed commit message

This PR is to fix the scan_frequency default value to 1 minute. It was set to 10s by mistake while all documentations said the default is 1m. For example: https://www.elastic.co/docs/reference/beats/filebeat/filebeat-input-aws-cloudwatch#_scan_frequency

This PR also added some debug entries around start time and end time for API calls.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

I dont think so.

@kaiyan-sheng kaiyan-sheng self-assigned this May 9, 2025
@kaiyan-sheng kaiyan-sheng requested a review from a team as a code owner May 9, 2025 18:17
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 9, 2025
Copy link
Contributor

mergify bot commented May 9, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaiyan-sheng? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@kaiyan-sheng kaiyan-sheng added Team:obs-ds-hosted-services Label for the Observability Hosted Services team backport-active-all Automated backport with mergify to all the active branches labels May 9, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/obs-ds-hosted-services (Team:obs-ds-hosted-services)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label May 9, 2025
Copy link
Contributor

@Kavindu-Dodan Kavindu-Dodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching this 🙌

@kaiyan-sheng kaiyan-sheng merged commit b6ce2c1 into elastic:main May 19, 2025
31 checks passed
@kaiyan-sheng kaiyan-sheng deleted the scan_freq branch May 19, 2025 20:56
Copy link
Contributor

@Mergifyio backport 8.17 8.18 8.19 9.0

Copy link
Contributor

mergify bot commented May 19, 2025

backport 8.17 8.18 8.19 9.0

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 19, 2025
mergify bot pushed a commit that referenced this pull request May 19, 2025
mergify bot pushed a commit that referenced this pull request May 19, 2025
mergify bot pushed a commit that referenced this pull request May 19, 2025
kaiyan-sheng added a commit that referenced this pull request May 20, 2025
(cherry picked from commit b6ce2c1)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng added a commit that referenced this pull request May 20, 2025
(cherry picked from commit b6ce2c1)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng added a commit that referenced this pull request May 20, 2025
(cherry picked from commit b6ce2c1)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
kaiyan-sheng added a commit that referenced this pull request May 20, 2025
(cherry picked from commit b6ce2c1)

Co-authored-by: kaiyan-sheng <kaiyan.sheng@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-all Automated backport with mergify to all the active branches bug Team:obs-ds-hosted-services Label for the Observability Hosted Services team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants