-
Notifications
You must be signed in to change notification settings - Fork 5k
[Filebeat] Use existing constant for FIPS distribution #45053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Filebeat] Use existing constant for FIPS distribution #45053
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
CI is failing like so:
This failure is unrelated to the changes in this PR. It can also be seen on
|
@ycombinator the flaky test PR is merged. |
9af3933
to
c85cdda
Compare
(cherry picked from commit 6798fe5)
(cherry picked from commit 6798fe5)
(cherry picked from commit 6798fe5)
(cherry picked from commit 6798fe5)
(cherry picked from commit 6798fe5)
Proposed commit message
This PR is a follow up to #45036. In that PR, a new constant was introduced in libbeat,
common.FIPSMode
to determine if we're running a FIPS-capable distribution of a Beat or not. Turns out there was already such a constant in place,version.FIPSDistribution
. So this PR here deletescommon.FIPSMode
and reusesversion.FIPSDistribution
instead.Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
In an environment configured for FIPS, i.e. with the Microsoft Go fork installed and with the OpenSSL FIPS provider installed: