Skip to content

build(deps): bump github.com/lib/pq from 1.10.3 to 1.10.9 #45184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jul 4, 2025

Bumps github.com/lib/pq from 1.10.3 to 1.10.9.

Release notes

Sourced from github.com/lib/pq's releases.

v1.10.9

  • Fixes backwards incompat bug with 1.13.
  • Fixes pgpass issue

v1.10.4

  • Keep track of (context cancelled) error on connection.
  • Fix android build
Commits
  • 2a217b9 add version check for go 1.15 (#1123)
  • d8d93a3 fix handle pgpass (#1120)
  • c10fcfe remove stray debugging code
  • 96e73eb conn: Implement driver.Validator, SessionResetter for cancelation
  • 922c00e Update codeql-analysis.yml
  • a2a3173 Update test.yml
  • 3a6282f Reduced the complexity of handlePgpass (#1101)
  • 133ac67 Improved the performance of CopyIn and CopyInSchema and added BufferQuoteIden...
  • d5affd5 Merge pull request #1088 from kelvich/sni_support
  • d65e6ae Merge pull request #1083 from nhooyr/fix-receiver-51e2
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [github.com/lib/pq](https://github.com/lib/pq) from 1.10.3 to 1.10.9.
- [Release notes](https://github.com/lib/pq/releases)
- [Commits](lib/pq@v1.10.3...v1.10.9)

---
updated-dependencies:
- dependency-name: github.com/lib/pq
  dependency-version: 1.10.9
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added automation dependabot GitHub Dependabot Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team labels Jul 4, 2025
@dependabot dependabot bot requested a review from a team as a code owner July 4, 2025 06:09
@dependabot dependabot bot added automation Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team dependabot GitHub Dependabot labels Jul 4, 2025
Copy link
Contributor

github-actions bot commented Jul 4, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Jul 4, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @dependabot[bot]? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@shmsr shmsr self-assigned this Jul 4, 2025
@shmsr
Copy link
Member

shmsr commented Jul 8, 2025

NOTE: We should ideally be using https://github.com/jackc/pgx as this is under active development; it is highly unlikely that github/lib/pq will get new features as per the README. So, to be able to work with the latest Postgres, it is better if we move to use pgx instead.

From the commit tree between 2 versions, it does not seem like there was a change that could potentially break things for existing users.

@shmsr shmsr requested a review from a team July 10, 2025 15:32
@ishleenk17
Copy link
Member

@shmsr : Could we please add the test details here.

@shmsr
Copy link
Member

shmsr commented Jul 14, 2025

Test Plan: PostgreSQL Module

Test Environment

  • PostgreSQL Version: 12.x
  • github.com/lib/pq Version: 1.10.9 (upgraded from 1.10.3)
  • Connection: postgres://localhost:5432?sslmode=disable
  • Credentials: postgres/postgres

Test Results

Test Case Status Notes
Basic Connectivity
Database Metricset
BGWriter Metricset
Activity Metricset
Statement Metricset
All Metricsets Ran it for a while to check if connections are constantly rising
Invalid Connection
Diff of documents produced by Postgres module with older v/s newer version of the lib The diff seems to be correct and I do not see any any issues

@shmsr shmsr enabled auto-merge (squash) July 14, 2025 08:34
@tommyers-elastic
Copy link
Contributor

NOTE: We should ideally be using https://github.com/jackc/pgx as this is under active development; it is highly unlikely that github/lib/pq will get new features as per the README. So, to be able to work with the latest Postgres, it is better if we move to use pgx instead.

From the commit tree between 2 versions, it does not seem like there was a change that could potentially break things for existing users.

where is this note from?

@shmsr
Copy link
Member

shmsr commented Jul 14, 2025

github.com/lib/pq

Here: https://github.com/lib/pq?tab=readme-ov-file#status

NOTE: We should ideally be using https://github.com/jackc/pgx as this is under active development; it is highly unlikely that github/lib/pq will get new features as per the README. So, to be able to work with the latest Postgres, it is better if we move to use pgx instead.

From the commit tree between 2 versions, it does not seem like there was a change that could potentially break things for existing users.

where is this note from?

Here: https://github.com/lib/pq?tab=readme-ov-file#status

@shmsr
Copy link
Member

shmsr commented Jul 14, 2025

Waiting the for CI to be fixed. Fix is currently being worked on.

@shmsr shmsr requested a review from a team July 15, 2025 08:55
@shmsr shmsr removed the request for review from a team July 15, 2025 09:45
@shmsr
Copy link
Member

shmsr commented Jul 16, 2025

@tommyers-elastic / @lalit-satapathy Can you please approve this PR?

@shmsr shmsr requested a review from a team July 16, 2025 12:02
@shmsr shmsr merged commit a4f743f into main Jul 18, 2025
205 of 206 checks passed
@shmsr shmsr deleted the dependabot/go_modules/main/github.com/lib/pq-1.10.9 branch July 18, 2025 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automation dependabot GitHub Dependabot Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants