Skip to content

[AutoOps] Include Missing Total Size #45205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 9, 2025
Merged

[AutoOps] Include Missing Total Size #45205

merged 1 commit into from
Jul 9, 2025

Conversation

pickypg
Copy link
Member

@pickypg pickypg commented Jul 4, 2025

This includes the 'total' data set size in addition to just the size in bytes.

Proposed commit message

Send the missing total_data_set_size_in_bytes alongside the size_in_bytes.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None. Unreleased code.

Author's Checklist

  • Node stats should produce size_in_bytes with total_data_set_size_in_bytes

How to test this PR locally

Run the node_stats metricset and verify the total_data_set_size_in_bytes is included in the documents.

@pickypg
[AutoOps] Include Missing Total Size
d804b09 
This includes the 'total' data set size in addition to just the
size in bytes.
@pickypg pickypg self-assigned this Jul 4, 2025
@pickypg pickypg requested a review from a team as a code owner July 4, 2025 21:46
@pickypg pickypg added release-note:skip The PR should be ignored when processing the changelog Team:Opex backport-9.1 Automated backport to the 9.1 branch labels Jul 4, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 4, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@pickypg pickypg enabled auto-merge (squash) July 4, 2025 21:46
@pickypg pickypg added the bug label Jul 4, 2025
romulo-batista-elastic
romulo-batista-elastic approved these changes Jul 9, 2025
View reviewed changes
Copy link
Contributor

@romulo-batista-elastic romulo-batista-elastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just have one question. Don’t remember seeing the ingestion part of it. Are we already ingesting the total_data_set_size_in_bytes?

@pickypg pickypg merged commit d7e07b0 into main Jul 9, 2025
35 checks passed
@pickypg pickypg deleted the autoops/add-total branch July 9, 2025 08:20
mergify bot pushed a commit that referenced this pull request Jul 9, 2025
@pickypg @mergify
[AutoOps] Include Missing Total Size (#45205)
1ed569d 
This includes the 'total' data set size in addition to just the
size in bytes.

(cherry picked from commit d7e07b0)
@mergify mergify bot mentioned this pull request Jul 9, 2025
Merged
7 tasks
pickypg added a commit that referenced this pull request Jul 9, 2025
@mergify @pickypg
[AutoOps] Include Missing Total Size (#45205) (#45253)
66df4e1 
This includes the 'total' data set size in addition to just the
size in bytes.

(cherry picked from commit d7e07b0)

Co-authored-by: Chris Earle <pickypg@users.noreply.github.com>
@khushijain21 khushijain21 mentioned this pull request Jul 15, 2025
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romulo-batista-elastic romulo-batista-elastic romulo-batista-elastic approved these changes

Assignees

@pickypg pickypg

Labels
backport-9.1 Automated backport to the 9.1 branch bug release-note:skip The PR should be ignored when processing the changelog Team:Opex
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pickypg @romulo-batista-elastic