Skip to content

Update user agent #45251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jul 21, 2025
Merged

Update user agent #45251

merged 13 commits into from
Jul 21, 2025

Conversation

graphaelli
Copy link
Member

@graphaelli graphaelli commented Jul 9, 2025

Proposed commit message

Update default user agent to distinguish between all beat modes:

  • Standalone indicates that the beat is not running under agent.
  • Unmanaged indicates that the beat is running under agent but not managed by Fleet.
  • Managed indicates that the beat is running under agent and managed by Fleet.

privilege mode information is only exposed under agent

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Users relying on specific user agents could be impacted. We've made no guarantees of stability for those and the only parts that changes are in the comments section.

Author's Checklist

  • verify user agent from a standalone agent
  • verify user agent from an unmanaged agent
  • verify user agent from a managed agent

* managed - under agent and using fleet
* standalone - under agent and not using fleet
* unmanaged - not under agent

privilege mode information is only exposed under agent
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 9, 2025
Copy link
Contributor

github-actions bot commented Jul 9, 2025

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Jul 9, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @graphaelli? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@graphaelli graphaelli marked this pull request as ready for review July 10, 2025 19:51
@graphaelli graphaelli requested review from a team as code owners July 10, 2025 19:51
@graphaelli graphaelli requested review from AndersonQ and rdner July 10, 2025 19:51
@graphaelli graphaelli added backport-9.1 Automated backport to the 9.1 branch backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team and removed backport-9.1 Automated backport to the 9.1 branch labels Jul 10, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 10, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@pierrehilbert
Copy link
Collaborator

@graphaelli it looks like I don't have permission to write on your branch so please run make update to make the CI happy by updating NOTICE.txt and go.sum with the up to date information about the elastic-agent-libs

@AndersonQ
Copy link
Member

the tests for user agent aren't passing either. Could you check if it's you code or if they need to be updated?

Copy link
Contributor

mergify bot commented Jul 11, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b update-user-agent upstream/update-user-agent
git merge upstream/main
git push upstream update-user-agent

@pierrehilbert
Copy link
Collaborator

/test

@graphaelli graphaelli merged commit 2a99bfa into elastic:main Jul 21, 2025
205 checks passed
@graphaelli graphaelli deleted the update-user-agent branch July 21, 2025 22:05
Copy link
Contributor

@Mergifyio backport 9.0 9.1

Copy link
Contributor

mergify bot commented Jul 21, 2025

backport 9.0 9.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request Jul 21, 2025
distinguish between all beat modes:

* Standalone indicates that the beat is not running under agent.
* Unmanaged indicates that the beat is running under agent but not managed by Fleet.
* Managed indicates that the beat is running under agent and managed by Fleet.

privilege mode information is only exposed under agent

(cherry picked from commit 2a99bfa)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
mergify bot pushed a commit that referenced this pull request Jul 21, 2025
distinguish between all beat modes:

* Standalone indicates that the beat is not running under agent.
* Unmanaged indicates that the beat is running under agent but not managed by Fleet.
* Managed indicates that the beat is running under agent and managed by Fleet.

privilege mode information is only exposed under agent

(cherry picked from commit 2a99bfa)

# Conflicts:
#	NOTICE.txt
#	go.mod
#	go.sum
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches enhancement Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants