-
Notifications
You must be signed in to change notification settings - Fork 5k
refactor: replace x/exp/maps with stdlib maps #45274
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
maps was added to the stdlib in new go versions replace old x/exp/maps with stdlib package
This pull request doesn't have a |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
x-pack/metricbeat/module/autoops_es/tasks_management/parse_child_nodes_test.go
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nevermind, the diff only showed that line for some reason. Reloading showed me the updated imports. Do we need slices.Collect
?
yeah :( |
This pull request is now in conflicts. Could you fix it? 🙏
|
Proposed commit message
maps was added to the stdlib in new go versions
replace old x/exp/maps with stdlib package
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs