Skip to content

[Chore] Replace global logger with local logger #11 #45285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 37 commits into from
Jul 18, 2025
Merged

[Chore] Replace global logger with local logger #11 #45285

merged 37 commits into from
Jul 18, 2025
+481 −383

Conversation

khushijain21
Copy link
Contributor

@khushijain21 khushijain21 commented Jul 10, 2025 •
edited
Loading

Proposed commit message

With this PR - except libbeat/autodiscover and libbeat/plugin - all libbeat folder are global logger free.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 10, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @khushijain21? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

khushijain21
khushijain21 commented Jul 10, 2025
View reviewed changes
khushijain21
khushijain21 commented Jul 10, 2025
View reviewed changes
khushijain21
khushijain21 commented Jul 10, 2025
View reviewed changes
@khushijain21 khushijain21 added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jul 10, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 10, 2025
@khushijain21 khushijain21 added needs_team Indicates that the issue/PR needs a Team:* label Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Jul 10, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 10, 2025
@khushijain21 khushijain21 added Team:obs-ds-hosted-services Label for the Observability Hosted Services team needs_team Indicates that the issue/PR needs a Team:* label labels Jul 10, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 10, 2025
@khushijain21 khushijain21 added needs_team Indicates that the issue/PR needs a Team:* label Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution labels Jul 10, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 10, 2025
@khushijain21 khushijain21 added needs_team Indicates that the issue/PR needs a Team:* label backport-8.19 Automated backport to the 8.19 branch labels Jul 10, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 10, 2025
@khushijain21 khushijain21 marked this pull request as ready for review July 10, 2025 11:14
@khushijain21 khushijain21 requested review from a team as code owners July 10, 2025 11:15
belimawr
belimawr reviewed Jul 16, 2025
View reviewed changes
Copy link
Contributor

@belimawr belimawr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for updating the tests in Filestream @khushijain21!!

I only looked at the Filestream part, it looks great!

leehinman
leehinman approved these changes Jul 16, 2025
View reviewed changes
Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

efd6
efd6 reviewed Jul 16, 2025
View reviewed changes
@khushijain21 khushijain21 requested a review from efd6 July 17, 2025 05:56
mcapell
mcapell reviewed Jul 17, 2025
View reviewed changes
swiatekm
swiatekm approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@swiatekm swiatekm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Kubernetes module and processor changes LGTM.

@rdner
Copy link
Member

rdner commented Jul 17, 2025 •
edited
Loading

@khushijain21 There is a syntax error that fails the CI now, once fixed I can also review.

@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 17, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b locallogger11 upstream/locallogger11
git merge upstream/main
git push upstream locallogger11

efd6
efd6 approved these changes Jul 17, 2025
View reviewed changes
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SSI-owned files LGTM

@khushijain21 khushijain21 enabled auto-merge (squash) July 18, 2025 05:18
@khushijain21 khushijain21 disabled auto-merge July 18, 2025 07:09
rdner
rdner reviewed Jul 18, 2025
View reviewed changes
@khushijain21 khushijain21 requested a review from rdner July 18, 2025 09:18
@khushijain21
Copy link
Contributor Author

@rdner can you take a look now?

rdner
rdner approved these changes Jul 18, 2025
View reviewed changes
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.
Thank you very much for doing this!

@khushijain21 khushijain21 enabled auto-merge (squash) July 18, 2025 09:51
@khushijain21 khushijain21 merged commit 1a9498d into elastic:main Jul 18, 2025
246 of 249 checks passed
mergify bot pushed a commit that referenced this pull request Jul 18, 2025
@khushijain21 @mergify
[Chore] Replace global logger with local logger #11 (#45285)
1e9ab5a 
* [Chore] Replace global logger with local logger #11

(cherry picked from commit 1a9498d)

# Conflicts:
#	filebeat/input/filestream/config.go
#	filebeat/input/filestream/filestream_test.go
#	filebeat/input/filestream/input.go
#	libbeat/cfgfile/reload_test.go
#	libbeat/otelbeat/oteltranslate/outputs/elasticsearch/config_otel_test.go
#	x-pack/libbeat/outputs/otelconsumer/otelconsumer.go
@mergify mergify bot mentioned this pull request Jul 18, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr belimawr left review comments

@rdner rdner rdner approved these changes

@mcapell mcapell mcapell approved these changes

@mjwolf mjwolf mjwolf approved these changes

@shmsr shmsr shmsr approved these changes

@nfritts nfritts nfritts approved these changes

@leehinman leehinman leehinman approved these changes

@andrzej-stencel andrzej-stencel andrzej-stencel approved these changes

@efd6 efd6 efd6 approved these changes

@swiatekm swiatekm swiatekm approved these changes

@VihasMakwana VihasMakwana Awaiting requested review from VihasMakwana VihasMakwana is a code owner automatically assigned from elastic/elastic-agent-data-plane

@michel-laterman michel-laterman Awaiting requested review from michel-laterman michel-laterman is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@khushijain21 khushijain21

Labels
backport-8.19 Automated backport to the 8.19 branch Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:obs-ds-hosted-services Label for the Observability Hosted Services team Team:Obs-InfraObs Label for the Observability Infrastructure Monitoring team Team:Security-Deployment and Devices Deployment and Devices Team in Security Solution Team:Security-Linux Platform Linux Platform Team in Security Solution Team:Security-Service Integrations Security Service Integrations Team Team:Security-Windows Platform Windows Platform Team in Security Solution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.