-
Notifications
You must be signed in to change notification settings - Fork 5k
feat(otel): add skeleton of Beat processor #45328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(otel): add skeleton of Beat processor #45328
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
@andrzej-stencel Correct me if I'm wrong, but this would replace the global processors for beat receivers, right? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as a "skeleton".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a NIT comment on the wording in the readme. It's optional, if don't wanna do it, it's fine.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Proposed commit message
Adds a no-op skeleton of a new OpenTelemetry Collector processor, Beat processor.
It is intended as a way to configure global Beat processors when running Beats as OTel receivers.
Checklist
[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature works[ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
See elastic/elastic-agent#8965 for including the processor in Elastic Agent.
Use cases
See README of the new processor.