Skip to content

x-pack/filebeat/input/cel: add support for token authentication #45359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 17, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 13, 2025

Proposed commit message

See title.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 self-assigned this Jul 13, 2025
@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch labels Jul 13, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 13, 2025
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@efd6 efd6 force-pushed the cel_token_auth branch from 313d8b6 to 95fbdaf Compare July 13, 2025 21:06
Copy link
Contributor

github-actions bot commented Jul 13, 2025

🔍 Preview links for changed docs

@efd6 efd6 marked this pull request as ready for review July 13, 2025 23:54
@efd6 efd6 requested review from a team as code owners July 13, 2025 23:54
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added some suggestions below to help users understand which versions support this new auth method. I used 9.1.0, but please change the version number in the suggestions if it's going into a different version.

Copy link
Contributor

mergify bot commented Jul 15, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b cel_token_auth upstream/cel_token_auth
git merge upstream/main
git push upstream cel_token_auth

@efd6 efd6 force-pushed the cel_token_auth branch from 23c1ec4 to 8039522 Compare July 15, 2025 20:56
@efd6 efd6 force-pushed the cel_token_auth branch from 8039522 to bbf9986 Compare July 16, 2025 00:00
Copy link
Contributor

@colleenmcginnis colleenmcginnis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@efd6 and I talked through my comments related to versioning. We'll address versioning in a follow-up PR.

Related: #45414.

@efd6 efd6 merged commit 5c91c96 into elastic:main Jul 17, 2025
33 of 36 checks passed
mergify bot pushed a commit that referenced this pull request Jul 17, 2025
(cherry picked from commit 5c91c96)

# Conflicts:
#	docs/reference/filebeat/filebeat-input-cel.md
mergify bot pushed a commit that referenced this pull request Jul 17, 2025
(cherry picked from commit 5c91c96)

# Conflicts:
#	docs/reference/filebeat/filebeat-input-cel.md
efd6 added a commit that referenced this pull request Jul 18, 2025
…en authentication (#45444)

* x-pack/filebeat/input/cel: add support for token authentication (#45359)

(cherry picked from commit 5c91c96)

# Conflicts:
#	docs/reference/filebeat/filebeat-input-cel.md

* remove irrelevant changelog entry
* fix cherry-pick conflict scars

---------

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6 added a commit that referenced this pull request Jul 18, 2025
…ken authentication (#45443)

* x-pack/filebeat/input/cel: add support for token authentication (#45359)

(cherry picked from commit 5c91c96)

# Conflicts:
#	docs/reference/filebeat/filebeat-input-cel.md

* remove cherry-picked markdown
* add asciidoc

---------

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants