Skip to content

x-pack/filebeat/input/httpjson: allow empty cursor template values to be ignored by health status updates #45361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025

Conversation

efd6
Copy link
Contributor

@efd6 efd6 commented Jul 14, 2025

Proposed commit message

x-pack/filebeat/input/httpjson: allow empty cursor template values to be ignored by health status updates

Health status changes are evaluated in CI for integrations and in some
cases (aws.guardduty is the provocation here), there is a failed/empty
evaluation. So allow ignore_empty_value configurations for cursor
entries to also be ignored for health status updates, instead of being
noted as a health degradation.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@efd6 efd6 self-assigned this Jul 14, 2025
@efd6 efd6 added enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team backport-9.0 Automated backport to the 9.0 branch backport-8.19 Automated backport to the 8.19 branch backport-9.1 Automated backport to the 9.1 branch labels Jul 14, 2025
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jul 14, 2025
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

… be ignored by health status updates

Health status changes are evaluated in CI for integrations and in some
cases (aws.guardduty is the provocation here), there is a failed/empty
evaluation. So allow ignore_empty_value configurations for cursor
entries to also be ignored for health status updates, instead of being
noted as a health degradation.
@efd6 efd6 force-pushed the i14491-httpjson branch from b5b9372 to b61ef6e Compare July 14, 2025 06:44
@efd6 efd6 marked this pull request as ready for review July 14, 2025 21:53
@efd6 efd6 requested a review from a team as a code owner July 14, 2025 21:53
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@efd6 efd6 changed the title x-pack/filebeat/input/httpjson: allow empty cursor template values to… x-pack/filebeat/input/httpjson: allow empty cursor template values to be ignored by health status updates Jul 15, 2025
@efd6 efd6 merged commit 0257f0c into elastic:main Jul 15, 2025
32 of 36 checks passed
mergify bot pushed a commit that referenced this pull request Jul 15, 2025
… be ignored by health status updates (#45361)

Health status changes are evaluated in CI for integrations and in some
cases (aws.guardduty is the provocation here), there is a failed/empty
evaluation. So allow ignore_empty_value configurations for cursor
entries to also be ignored for health status updates, instead of being
noted as a health degradation.

(cherry picked from commit 0257f0c)
mergify bot pushed a commit that referenced this pull request Jul 15, 2025
… be ignored by health status updates (#45361)

Health status changes are evaluated in CI for integrations and in some
cases (aws.guardduty is the provocation here), there is a failed/empty
evaluation. So allow ignore_empty_value configurations for cursor
entries to also be ignored for health status updates, instead of being
noted as a health degradation.

(cherry picked from commit 0257f0c)
mergify bot pushed a commit that referenced this pull request Jul 15, 2025
… be ignored by health status updates (#45361)

Health status changes are evaluated in CI for integrations and in some
cases (aws.guardduty is the provocation here), there is a failed/empty
evaluation. So allow ignore_empty_value configurations for cursor
entries to also be ignored for health status updates, instead of being
noted as a health degradation.

(cherry picked from commit 0257f0c)
efd6 added a commit that referenced this pull request Jul 15, 2025
… be ignored by health status updates (#45361) (#45396)

Health status changes are evaluated in CI for integrations and in some
cases (aws.guardduty is the provocation here), there is a failed/empty
evaluation. So allow ignore_empty_value configurations for cursor
entries to also be ignored for health status updates, instead of being
noted as a health degradation.

(cherry picked from commit 0257f0c)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6 added a commit that referenced this pull request Jul 15, 2025
… be ignored by health status updates (#45361) (#45398)

Health status changes are evaluated in CI for integrations and in some
cases (aws.guardduty is the provocation here), there is a failed/empty
evaluation. So allow ignore_empty_value configurations for cursor
entries to also be ignored for health status updates, instead of being
noted as a health degradation.

(cherry picked from commit 0257f0c)

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
efd6 added a commit that referenced this pull request Jul 15, 2025
…rsor template values to be ignored by health status updates (#45397)

* x-pack/filebeat/input/httpjson: allow empty cursor template values to be ignored by health status updates (#45361)

Health status changes are evaluated in CI for integrations and in some
cases (aws.guardduty is the provocation here), there is a failed/empty
evaluation. So allow ignore_empty_value configurations for cursor
entries to also be ignored for health status updates, instead of being
noted as a health degradation.

(cherry picked from commit 0257f0c)

* remove irrelevant changelog entries

---------

Co-authored-by: Dan Kortschak <dan.kortschak@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.19 Automated backport to the 8.19 branch backport-9.0 Automated backport to the 9.0 branch backport-9.1 Automated backport to the 9.1 branch enhancement Filebeat Filebeat Team:Security-Service Integrations Security Service Integrations Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants