-
Notifications
You must be signed in to change notification settings - Fork 44
remove evidence field from CIS GCP #3429
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @orouz? 🙏
|
common.calculate_result(has_cusomter_encrypted_key), | ||
data_adapter.resource, | ||
) | ||
result := common.generate_evaluation_result(common.calculate_result(has_cusomter_encrypted_key)) | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the common theme in this PR - replace generate_result_without_expected
with generate_evaluation_result
which results in sending an object with just evaluation
field instead of a one including evidence
too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
- Before merging please verify that this PR didn't change the number of failed/passed findings for the same dataset.
- Merge is blocked on the corresponding Kibana PR.
@orouz should it be backported to |
generally speaking, yeah. but that's in June 24, which isn't so far from now, and i'm waiting to see the customer feedback before merging this to main or any backports. |
Should also to backport to 9.x? |
We agreed to backport to the next patch versions ( |
Summary of your changes
this PR removes the
result.evidence
field from all CIS GCP rules by omitting it from the rego rules. the motivation for this is to reduce raw findings size. regardless, as seen in the changed files, majority of the rules already send the entire resource as the evidence, and since that resource is already available asresource.raw
we can just point to it in kibana instead of duplicating it.findings count and size were checked with:
POST logs-cloud_security_posture.findings-default/_count
GET _cat/indices/logs-cloud_security_posture.findings-default?v&h=index,store.size
main
)1322
1322
1126.4kb
914.3kb
this makes the default findings index about
18.83%
smallerRelated Issues