-
Notifications
You must be signed in to change notification settings - Fork 23
Add external links to navigation #1613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🔍 Preview links for changed docs |
@bmorelli25 See the GitHub repository link in https://docs-v3-preview.elastic.dev/elastic/docs-builder/pull/1613/configure/content-set/navigation |
oooooh I immediately want to use this to add a link to the Elasticsearch reference docs in the Elasticsearch solution nav 😍 would this be a valid use case? |
There's a thread in #elastic-docs-v3 about this. There are two use cases and that's the other one. Not sure if Fabri is also working on that 🧙 |
@Mpdreamz @bmorelli25 After melting Claude's brain, it looks like adding crosslinks validation and rendering to the toc is too much. LLMs being unable to figure this out suggests that crosslinks depend deeply on the overall architecture, but correct me if I'm wrong. For a quick solution, I'd rather show external links as they appear now and, if they start with |
I am going to mull over this one over the weekend. For sure I don't want links to We could support:
|
@Mpdreamz I love that. Any hint on how to achieve that though? I mean the crosslinks in the toc. |
You need the current
After We already do something similar to ensure the validity of navigation index:
|
CSS issue solved for this particular PR, @Mpdreamz! We shouldn't abuse this system though, I agree. |
We can probably close this one if #1615 gets merged, though it'd be a separate functionality. |
Fixes #1593