Skip to content

Add service.name to well-defined fields and allow configuration throu… #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

eirikbell
Copy link

ECS 1.6.0 defines service.name as a configurable field to help filter logs by service. Additionally this field is used by kibana to display the name of the service logging an entry when correlating logs in distributed tracing. When using this formatter, adding service.name as a field on the log entry will add it within the nested custom fields.

This PR will enable the possibility of configuring formatter with a service name for all log entries and also overrides this value if entry.Data already contain a value for service.name.

@cla-checker-service
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
c750059, 8fd1a4e

Please, read and sign the above mentioned agreement if you want to contribute to this project

@apmmachine
Copy link

❕ Build Aborted

The PR is not allowed to run in the CI yet

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Start Time: 2022-09-13T08:26:46.334+0000

  • Duration: 3 min 53 sec

Steps errors 2

Expand to view the steps failures

Load a resource file from a library
  • Took 0 min 0 sec . View more details here
  • Description: approval-list/elastic/ecs-logging-go-logrus.yml
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/eirikbell return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/eirikbell : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/eirikbell : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants