Skip to content

fix: solaris build support #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 30, 2025
Merged

Conversation

gaige
Copy link
Contributor

@gaige gaige commented Jun 29, 2025

What does this PR do?

The changes here are intended solely to add compatibility for builing on Solaris-based operating systems.
Changes are only to the build directives and thus will have no effect on other OS.

Why is it important?

In ordet to enable building beats for Solaris, Illumos, and SmartOS.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

Author's Checklist

  • Ensure no negative effects on other OS

Related issues

@gaige gaige requested a review from a team as a code owner June 29, 2025 12:48
@gaige gaige requested review from belimawr and rdner and removed request for a team June 29, 2025 12:48
@gaige gaige force-pushed the solaris-compatible branch from 9349688 to b800678 Compare June 29, 2025 13:40
Copy link
Member

@mauri870 mauri870 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw your accompanying PR in Beats (elastic/beats#45105). Just to make sure we're on the same page: we don't have plans to support compiling to Solaris officially. This is purely community-driven work, and it may eventually break if users stop fixing issues.

That said, thanks for the effort on keeping the Solaris build working!

@mauri870
Copy link
Member

/test

1 similar comment
@mauri870
Copy link
Member

/test

@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Cleanup labels Jun 30, 2025
@mauri870 mauri870 merged commit 970079b into elastic:main Jun 30, 2025
5 checks passed
@gaige
Copy link
Contributor Author

gaige commented Jun 30, 2025

Thanks! Understood on the support side, but it’s super helpful not to have to maintain a fork :-)

For the time being, I’m interested in keeping things going. Maybe it’ll inspire some other SmartOS or Solaris folks to pitch in.

@gaige gaige deleted the solaris-compatible branch June 30, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants