Skip to content

feat(otel-node): set stable http semconv as default #669

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 15 commits into from
Mar 28, 2025

Conversation

david-luna
Copy link
Member

@david-luna david-luna commented Mar 21, 2025

Closes: #667

Note: I'm curious why the mockotlpserver is getting now the spans from the GCP resource detector. I've added another filter in testutils.js until the issue in the detector is fixed.

@david-luna david-luna marked this pull request as ready for review March 25, 2025 11:22
@david-luna david-luna requested a review from trentm March 25, 2025 11:22
@trentm
Copy link
Member

trentm commented Mar 25, 2025

Note: I'm curious why the mockotlpserver is getting now the spans from the GCP resource detector.

Wasn't it always getting them? Hrm, perhaps not.

@david-luna david-luna requested a review from trentm March 27, 2025 11:51
Copy link
Member

@trentm trentm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool.
Should add a changelog entry.

@david-luna david-luna merged commit af98ab1 into main Mar 28, 2025
9 checks passed
@david-luna david-luna deleted the dluna-http-stable-semvconv-opt-in branch March 28, 2025 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

default HTTP semconv to use the newer stable conventions
2 participants