Avoid encoding html entities in JSON documents #1464
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON encoders in Go standard library encode HTML special characters by default, so the resulting JSON is safe to use in HTML documents. In sample documents and test results in packages we want the raw JSON, so we can see the actual content that would be ingested when using the integration.
|
test integrations |
|
test integrations |
|
Created or updated PR in integrations repostiory to test this vesrion. Check elastic/integrations#7917 |
|
/test |
💚 Build Succeeded
History
cc @jsoriano |
mrodm
approved these changes
Sep 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid encoding HTML entities in JSON documents generated by tests.
The main JSON "Marshaling" helpers also encode HTML entities to reduce
the risk of injections through JSON documents embedded in HTML.
In documents generated by package tests, we want to have the raw document,
as found in Elasticsearch.
This change changes the rendering behaviour for packages starting on 2.12.0,
so these entities are not encoded.
Fix #320.