Skip to content

Remove xpack.fleet.agents.elasticsearch.hosts config entry from kibana.yml #1473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2023
Merged

Remove xpack.fleet.agents.elasticsearch.hosts config entry from kibana.yml #1473

merged 1 commit into from
Sep 27, 2023

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Sep 26, 2023 •
edited
Loading

This PR removes the fleet server config xpack.fleet.agents.elasticsearch.hostsas mentioned in elastic/kibana#160002

That config entry would be kept for backwards compatibility for kibana versions < 8.11.0-SNAPSHOT.

Starting with 8.11.0-SNAPSHOT it will just use xpack.fleet.outputs

Tested with these versions

elastic-package stack up -v -d --version 8.11.0-SNAPSHOT  # just used xpack.fleet.outputs in kibana.yml
elastic-package stack down -v
elastic-package stack up -v -d --version 8.10.0-SNAPSHOT  # both configs are set in kibana.yml
elastic-package stack down -v

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

@mrodm mrodm self-assigned this Sep 27, 2023
ruflin
ruflin approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the PR with 8.11.0-SNAPSHOT and works as expected.

@mrodm mrodm marked this pull request as ready for review September 27, 2023 07:56
@mrodm mrodm requested a review from a team September 27, 2023 07:56
@mrodm mrodm changed the title Remove xpack.fleet.agents.elasticsearch.hosts config entry Remove xpack.fleet.agents.elasticsearch.hosts config entry from kibana.yml Sep 27, 2023
@mrodm mrodm merged commit a0fcfa8 into elastic:main Sep 27, 2023
@mrodm mrodm deleted the remove_fleet_config_entry branch September 27, 2023 08:16
@chrisberkhout chrisberkhout mentioned this pull request Oct 2, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

@ruflin ruflin ruflin approved these changes

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@mrodm mrodm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mrodm @elasticmachine @jsoriano @ruflin @juliaElastic