Skip to content

Update var used in google_cloud_auth #1518

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2023
Merged

Update var used in google_cloud_auth #1518

merged 1 commit into from
Oct 19, 2023

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Oct 19, 2023

This PR updates the variable used in google_cloud_auth to use the local variable

@mrodm mrodm self-assigned this Oct 19, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

cc @mrodm

@mrodm mrodm requested a review from a team October 19, 2023 15:35
jsoriano
jsoriano approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@jsoriano jsoriano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea what it was doing before, but change looks better :D

@mrodm mrodm merged commit af194a4 into elastic:main Oct 19, 2023
@mrodm mrodm deleted the use_local_vars_google_cloud branch October 19, 2023 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jsoriano jsoriano jsoriano approved these changes

Assignees

@mrodm mrodm

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrodm @elasticmachine @jsoriano