-
Notifications
You must be signed in to change notification settings - Fork 126
Add retries to kibana client #1563
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Did you test these changes creating a serverless project?
No... let me try... |
Tested to start and stop serverless four times, and all of them were successful, except one where elastic-agent failed to start due to some authentication error, that seemed unrelated to this change. Running up again in this case started the agent. I saw some retries querying status endpoints, and the debug logging was different. I have configured it to use the default |
💚 Build Succeeded
History
cc @jsoriano |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Tested to start and stop serverless four times, and all of them were successful, except one where elastic-agent failed to start due to some authentication error, that seemed unrelated to this change. Running up again in this case started the agent.
Thanks for checking this out !
I saw some retries querying status endpoints, and the debug logging was different. I have configured it to use the default slog logger that fulfils the requirements for retryablehttp and uses log under the hood as we do everywhere else.
First usage of slog
💪 At some point I would like to start using more that package
Adding it by now only to kibana client because for elasticsearch client we rely on the Go SDK, that has its own retry mechanisms.
As it is implemented, we can later consider using it in more places where an http client is used now.