Remove serverless credentials reset #2307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
commented
Dec 30, 2024
| trailer: {} | ||
| content_length: 363 | ||
| uncompressed: false | ||
| body: '{"error":{"root_cause":[{"type":"api_not_available_exception","reason":"Request for uri [/_cluster/health] with method [GET] exists but is not available when running in serverless mode"}],"type":"api_not_available_exception","reason":"Request for uri [/_cluster/health] with method [GET] exists but is not available when running in serverless mode"},"status":410}' |
There was a problem hiding this comment.
See here a response from serverless for the _cluster/health API.
jsoriano
changed the title
💚 Build Succeeded
cc @jsoriano |
This was referenced Dec 31, 2024
jsoriano
added a commit
that referenced
this pull request
Jan 7, 2025
When creating new recordings for testing, tests that already have recordings fail if the host doesn't match. This happens when recording from environments that don't use the usual local values, as for example in the test case added for serverless in #2307. This can even interfere with any other environment variable set by elastic-package stack shellinit. With this change environment variables are only used to initialize the client when creating new recording files and not in subsequent executions.
mrodm
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the internal
_reset-internal-credentialsAPI to obtain the credentials used for serverless stacks managed byelastic-package. But this API is only available to elastic employees.There were two reasons to obtain credentials this way:
_cluster/health). In this case, if normal credentials are used, it returns HTTP status 410 (Gone) if the cluster is alive and the credentials are valid, I think we can consider this as an OK for this case. This will be also needed in any case for API keys support, because API keys don't have access to these internal APIs.elastic-packageoperations.As these reasons are not strong enough now, I think it would be better if we just avoid these resets.
Relates to #1633, where it was observed that we need to make
elastic-packagework with non-internal credentials.