Skip to content

Add detection of source.mode synthetics for 8.17.2 onwards #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented Feb 12, 2025

Relates #2397

This PR adds support to detect synthetic mode from 8.17.2 onwards.

It looks like that starting in this version this mode is declared under the settings object:

{
  "template": {
    "settings": {
      "index": {
        "mapping": {
          "total_fields": {
            "limit": "1000",
            "ignore_dynamic_beyond_limit": "true"
          },
          "source": {
            "mode": "synthetic"
          }
        },
      }
    }
  }
}

Before this (in 8.17.1), there is also a warning message in the API response:

#! Configuring source mode in mappings is deprecated and will be removed in future versions. Use [index.mapping.source.mode] index setting instead.
{
  "template": {
    "mappings": {
      "_source": {
        "mode": "synthetic"
      }
    }
  }
}

How to test this PR locally

elastic-package stack up -v -d --version 8.17.2

cd test/packages/other/synthetic_mode

elastic-package test system -v

# Using DevTools query to check the API response to read the source mode
# POST /_index_template/_simulate_index/metrics-synthetic_mode.synthetic-25370-simulated

elastic-package stack down -v

@mrodm mrodm requested a review from a team February 12, 2025 13:24
@mrodm mrodm self-assigned this Feb 12, 2025
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 12, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

History

cc @mrodm

@mrodm mrodm merged commit 265c292 into elastic:main Feb 12, 2025
3 checks passed
@mrodm mrodm deleted the fix_detection_synthetic_mode branch February 12, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants