Enable validation based on mappings by default #2410
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
force-pushed
the
enable_validation_mappings_default
branch
from
9ace2a4 to
cd24f7f
Compare
mrodm
commented
Feb 14, 2025
| @@ -1646,7 +1646,7 @@ func (r *tester) validateTestScenario(ctx context.Context, result *testrunner.Re | |||
| } | |||
|
|
|||
| if r.fieldValidationMethod == mappingsMethod { | |||
| logger.Warn("Validation based on mappings enabled (technical preview)") | |||
| logger.Debug("Performing validation based on mappings") | |||
There was a problem hiding this comment.
Took the advantage of removing the technical preview status, since it is going to be enabled by default.
I thought that maybe this message could help to identify if the validation based on mappings has been executed or not. WDYT ?
💚 Build Succeeded
History
cc @mrodm |
jsoriano
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the validation based on mappings by default.
This validation will be run along with the validation based on fields. The latter is the validation performed until now.
Additionally, CI steps related to test packages adding the validation based on mappings have been deleted, since now all the packages should be tested with both (validated based on fields and mappings).